From ddb1b1adacdfc858ac0ea9d6c5ba445125a3a135 Mon Sep 17 00:00:00 2001
From: Rene Mewissen <rene@tantooine.myfirewall.org>
Date: Mon, 26 Jan 2026 15:14:18 +0100
Subject: [PATCH] use other methods

---
 .../tasks/apps/nextcloud/prereq.yml           | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/roles/webservers/tasks/apps/nextcloud/prereq.yml b/roles/webservers/tasks/apps/nextcloud/prereq.yml
index fbdcfa8..72d6361 100644
--- a/roles/webservers/tasks/apps/nextcloud/prereq.yml
+++ b/roles/webservers/tasks/apps/nextcloud/prereq.yml
@@ -6,24 +6,22 @@
       - apt-transport-https
       - software-properties-common
       - lsb-release
-      - ca-certificates
   when: ansible_facts['distribution'] in ["Debian", "Ubuntu", "Linux Mint"]
 
 - name: webservers | nextcloud | prereq | get php repo key
-  ansible.builtin.uri:
+  ansible.builtin.get_url:
     url: "https://packages.sury.org/php/apt.gpg"
-    dest: "/etc/apt/trusted.gpg.d/php.gpg"
+    dest: "/usr/share/keyrings/php-sury.gpg"
+    mode: '0644'
 
 - name: webservers | nextcloud | prereq | add php repo
-  ansible.builtin.lineinfile:
-    path: "/etc/apt/sources.list.d/php.list"
+  ansible.builtin.apt_repository:
+    repo: "deb [signed-by=/usr/share/keyrings/php-sury.gpg] https://packages.sury.org/php/ {{ ansible_facts['distribution_release'] | lower }} main"
     state: present
-    line: "deb https://packages.sury.org/php/ {{ ansible_facts['distribution_release'] | lower }} main"
-    create: True
-  
+    filename: php-sury
+    update_cache: true
+
 - name: webservers | nextcloud | prereq | install php
   ansible.builtin.package:
     state: latest
-    name: "{{ item.package }}"
-    update_cache: True
-  with_items: "{{ nextcloud_php_packages }}"
\ No newline at end of file
+    name: "{{ nextcloud_php_packages | map(attribute='package') | list }}"
\ No newline at end of file